Add profiler runs on regression #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddyurchenko
force-pushed
the
ddyurchenko/add-profiler-run-on-regression
branch
from
433d4a5
to
898b449
Compare
felixge
previously approved these changes
Mar 14, 2023
ddyurchenko
force-pushed
the
ddyurchenko/add-profiler-run-on-regression
branch
from
435334c
to
8f52069
Compare
ddyurchenko
force-pushed
the
ddyurchenko/add-profiler-run-on-regression
branch
from
8f52069
to
d4fa189
Compare
3 tasks
ddyurchenko
added a commit
that referenced
this pull request
Mar 17, 2023
* Add profiler runs on regression * Add uploading to DD backend * Remove duplication of code in bash scripts --------- Co-authored-by: Felix Geisendörfer <felix@datadoghq.com>
ddyurchenko
added a commit
that referenced
this pull request
Mar 17, 2023
* Add profiler runs on regression * Add uploading to DD backend * Remove duplication of code in bash scripts --------- Co-authored-by: Felix Geisendörfer <felix@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds profiler runs for benchmarks if regression was detected. This should add more confidence in results and allow to see what caused change in performance.
Motivation
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.