tracer: 128-bit trace id bug fixes #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the 128-bit trace id
ajgajg1134
approved these changes
Mar 17, 2023
knusbaum
approved these changes
Mar 17, 2023
katiehockman
changed the title
katiehockman
added a commit
that referenced
this pull request
Mar 27, 2023
- guarantee that the propagating tags have been set before reading them during extraction - only set _dd.p.tid if the top 64 bits is not empty or zero - always set _dd.p.tid to 16 characters, with padding if needed
katiehockman
added a commit
that referenced
this pull request
Mar 28, 2023
- guarantee that the propagating tags have been set before reading them during extraction - only set _dd.p.tid if the top 64 bits is not empty or zero - always set _dd.p.tid to 16 characters, with padding if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a few 128-bit bugs:
_dd.p.tidif the top 64 bits is not empty or zero_dd.p.tidto 16 characters, with padding if neededPR was a collaboration with @ajgajg1134 @knusbaum @lievan
Motivation
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.