Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracer: do not change the trace id for child spans #1814

Merged
merged 2 commits into from
Mar 17, 2023
Merged

tracer: do not change the trace id for child spans #1814

merged 2 commits into from
Mar 17, 2023

Conversation

katiehockman
Copy link
Contributor

What does this PR do?

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@katiehockman katiehockman changed the base branch from main to shared/128-bit March 17, 2023 19:10
@katiehockman katiehockman marked this pull request as ready for review March 17, 2023 19:16
@katiehockman katiehockman requested a review from a team March 17, 2023 19:16
@katiehockman katiehockman added this to the v1.49.0 milestone Mar 17, 2023
@katiehockman katiehockman merged commit 89048b3 into shared/128-bit Mar 17, 2023
@katiehockman katiehockman deleted the katiehockman/128-bit-refactor branch March 17, 2023 20:39
katiehockman added a commit that referenced this pull request Mar 27, 2023
@katiehockman
tracer: do not change the trace id for child spans (#1814)
6d29fe7
katiehockman added a commit that referenced this pull request Mar 27, 2023
@katiehockman
add the bug fix back from PR #1814
fef4698
katiehockman added a commit that referenced this pull request Mar 28, 2023
@katiehockman
tracer: do not change the trace id for child spans (#1814)
08a9ef8
katiehockman added a commit that referenced this pull request Mar 28, 2023
@katiehockman
add the bug fix back from PR #1814
19a64f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knusbaum knusbaum knusbaum approved these changes

@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.49.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@katiehockman @knusbaum @ajgajg1134