Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracer: add debug log for finished spans #1877

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Log finished spans in debug the same way we log started spans.

Motivation

Ease debugging and support.

Describe how to test/QA your changes

Unit tested.

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@ahmed-mez ahmed-mez added this to the v1.50.0 milestone Apr 7, 2023
@ahmed-mez ahmed-mez requested a review from a team April 7, 2023 12:55
@ahmed-mez ahmed-mez requested a review from a team as a code owner April 7, 2023 13:52
@ahmed-mez ahmed-mez removed the request for review from a team April 7, 2023 13:54
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@ahmed-mez ahmed-mez merged commit f56bd6f into main Apr 7, 2023
@ahmed-mez ahmed-mez deleted the ahmed/log-finished-spans branch April 7, 2023 14:10
@wittekm
Copy link

wittekm commented May 9, 2023

Thanks all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants