Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster CI: Optimize APM Parametric Tests #2070

Merged
merged 16 commits into from
Jun 26, 2023

Conversation

felixge
Copy link
Member

@felixge felixge commented Jun 25, 2023

What does this PR do?

  1. Speed up "Patch dd-trace-go version" step from 30s to 10s by using a replace directive in go.mod instead of using go get.
  2. Split "Run" step into "Build" and "Run" step and by moving away from the legacy parametric/run.sh script.
  3. Add "Cache venv" step to speedup build step from ~1m to ~10s
  4. Remove "Checkout Go" step that served no apparent purpose.

Together with #2068 this will allow running this pipeline as fast as 3min45s 🚀.

Motivation

See RFC: Faster CI for dd-trace-go 🚀 google doc.

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@pr-commenter
Copy link

pr-commenter bot commented Jun 25, 2023

Benchmarks

Benchmark execution time: 2023-06-26 13:05:56

Comparing candidate commit e19ea10 in PR branch felix.geisendoerfer/fast-ci-faster-parametric-tests with baseline commit ea87357 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@felixge felixge changed the title faster parametric? Faster CI: Optimize APM Parametric Tests Jun 25, 2023
@felixge felixge marked this pull request as ready for review June 25, 2023 19:52
@felixge felixge requested a review from a team as a code owner June 25, 2023 19:52
@felixge felixge mentioned this pull request Jun 26, 2023
2 tasks
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@felixge felixge merged commit 0348452 into main Jun 26, 2023
48 checks passed
@felixge felixge deleted the felix.geisendoerfer/fast-ci-faster-parametric-tests branch June 26, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants