Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtrace/tracer: added telemetry for context propagation #2103

Merged
merged 11 commits into from
Jul 28, 2023
Merged

ddtrace/tracer: added telemetry for context propagation #2103

merged 11 commits into from
Jul 28, 2023

Conversation

dianashevchenko
Copy link
Contributor

What does this PR do?

This PR adds two telemetry tags on app-started event

  • trace_propagation_style_inject
  • trace_propagation_style_extract

Will add a test case covering this functionality and env variable overriding when #2072 is merged

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@pr-commenter
Copy link

pr-commenter bot commented Jul 7, 2023 •
edited
Loading

Benchmarks

Benchmark execution time: 2023-07-28 14:09:28

Comparing candidate commit 6c0efbf in PR branch shevchenko/w3c-telemetry with baseline commit 066c0e3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 33 metrics, 0 unstable metrics.

github-actions[bot]
github-actions bot reviewed Jul 11, 2023
View reviewed changes
ddtrace/opentelemetry/telemetry_test.go Outdated Show resolved Hide resolved
ddtrace/opentelemetry/telemetry_test.go Outdated Show resolved Hide resolved
@dianashevchenko dianashevchenko marked this pull request as ready for review July 11, 2023 14:14
@dianashevchenko dianashevchenko requested a review from a team July 11, 2023 14:14
ajgajg1134
ajgajg1134 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

github-actions[bot]
github-actions bot reviewed Jul 28, 2023
View reviewed changes
ddtrace/opentelemetry/tracer_test.go Outdated Show resolved Hide resolved
ddtrace/opentelemetry/span.go Outdated Show resolved Hide resolved
@dianashevchenko dianashevchenko merged commit 3490331 into main Jul 28, 2023
52 checks passed
@dianashevchenko dianashevchenko deleted the shevchenko/w3c-telemetry branch July 28, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dianashevchenko @ajgajg1134