Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable profiling when run in AWS Lambda. #2216

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

purple4reina
Copy link
Contributor

What does this PR do?

When aws lambda runtime is detected, refuse to start profiler.

Motivation

Profiling is not currently supported in aws lambda. Node and Python are currently in public beta. Because Go is not included in this, customers would get charged for profiles that are potentially inaccurate.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@purple4reina purple4reina requested a review from a team as a code owner September 13, 2023 18:53
Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left a suggestion for how to structure this, mainly just prefer to make this package testable without having to inspect/modify private package variables where we can.

profiler/profiler.go Outdated Show resolved Hide resolved
profiler/profiler_test.go Outdated Show resolved Hide resolved
profiler/profiler_test.go Outdated Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Sep 13, 2023

Benchmarks

Benchmark execution time: 2023-09-13 20:39:47

Comparing candidate commit d83b09f in PR branch rey.abolofia/lambda-profile with baseline commit f8a0ac2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nsrip-dd nsrip-dd merged commit 9435e66 into main Sep 14, 2023
52 checks passed
@nsrip-dd nsrip-dd deleted the rey.abolofia/lambda-profile branch September 14, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants