Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: implement http.route in missing contribs #2234

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Sep 27, 2023

What does this PR do?

Implement http.route tag in the following contribs:

  • contrib/dimfeld/httptreemux.v5
  • contrib/gofiber/fiber.v2
  • contrib/emicklei/go-restful.v3
  • contrib/zenazn/goji.v1/web

Also added some tests and smaller refactors in other contribs.

Motivation

Consistent implementation of http.route across languages and frameworks

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Sep 27, 2023

Benchmarks

Benchmark execution time: 2023-10-23 09:15:26

Comparing candidate commit 6e282a2 in PR branch rarguelloF/http-route with baseline commit 00055c7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@rarguelloF rarguelloF changed the title WIP: contrib: implement http.route in missing contribs contrib: implement http.route in missing contribs Sep 28, 2023
@rarguelloF rarguelloF marked this pull request as ready for review September 28, 2023 13:59
@rarguelloF rarguelloF requested a review from a team September 28, 2023 13:59
@katiehockman katiehockman added the apm:ecosystem contrib/* related feature requests or bugs label Oct 6, 2023
@rarguelloF rarguelloF enabled auto-merge (squash) October 23, 2023 09:01
@rarguelloF rarguelloF merged commit e1a2437 into main Oct 23, 2023
51 of 52 checks passed
@rarguelloF rarguelloF deleted the rarguelloF/http-route branch October 23, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants