Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIT-8312 tracer/option: document service defaulting #2245

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Explain in a code comment why we don't set a global service name if defaulted to binary name.

Motivation

Address some confusing behavior that could be interpreted as bug (see #2240)

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ahmed-mez ahmed-mez enabled auto-merge (squash) October 2, 2023 08:06
@ahmed-mez ahmed-mez merged commit d91f79f into main Oct 2, 2023
50 of 51 checks passed
@ahmed-mez ahmed-mez deleted the ahmed/svc-comment branch October 2, 2023 08:06
@ahmed-mez ahmed-mez changed the title tracer/option: document service defaulting AIT-8312 tracer/option: document service defaulting Oct 3, 2023
@darccio darccio restored the ahmed/svc-comment branch November 16, 2023 15:41
@darccio darccio deleted the ahmed/svc-comment branch November 16, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants