Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use older Windows for Go 1.19 tests #2250

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

nsrip-dd
Copy link
Contributor

@nsrip-dd nsrip-dd commented Oct 4, 2023

What does this PR do?

Use windows-2019 runner when testing Go 1.19, since the windows-2022 image
has an incompatible C toolchain which breaks some of our tests.

This is a known issue, fixed in Go 1.20: golang/go#51007

Motivation

Keep CI green for Go 1.19.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@nsrip-dd nsrip-dd force-pushed the nick.ripley/old-windows-for-go119 branch from c8f53d0 to b51fe50 Compare October 4, 2023 14:38
@nsrip-dd nsrip-dd force-pushed the nick.ripley/old-windows-for-go119 branch from b51fe50 to 33514ce Compare October 4, 2023 14:43
@nsrip-dd
Copy link
Contributor Author

nsrip-dd commented Oct 4, 2023

Manual dispatch with 1.19 + windows-latest (to check that we detect that and switch to windows-2019): https://github.com/DataDog/dd-trace-go/actions/runs/6407656425/job/17394912271

Manual dispatch with 1.20 + windows-latest (to check that we use the latest windows for non-1.19): https://github.com/DataDog/dd-trace-go/actions/runs/6408001967/job/17396024737

@pr-commenter
Copy link

pr-commenter bot commented Oct 4, 2023

Benchmarks

Benchmark execution time: 2023-10-04 14:58:01

Comparing candidate commit 33514ce in PR branch nick.ripley/old-windows-for-go119 with baseline commit 6afa212 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@nsrip-dd nsrip-dd changed the title Use older Windows for Go 1.19 tests ci: use older Windows for Go 1.19 tests Oct 4, 2023
@nsrip-dd nsrip-dd marked this pull request as ready for review October 4, 2023 15:10
@nsrip-dd nsrip-dd requested a review from a team as a code owner October 4, 2023 15:10
@nsrip-dd nsrip-dd merged commit b4cc9ed into main Oct 4, 2023
55 checks passed
@nsrip-dd nsrip-dd deleted the nick.ripley/old-windows-for-go119 branch October 4, 2023 15:14
darccio pushed a commit that referenced this pull request Oct 5, 2023
Use windows-2019 runner when testing Go 1.19, since the windows-2022 image
has an incompatible C toolchain which breaks some of our tests.

(cherry picked from commit b4cc9ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants