ci: use older Windows for Go 1.19 tests #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsrip-dd
force-pushed
the
nick.ripley/old-windows-for-go119
branch
from
c8f53d0
to
b51fe50
Compare
nsrip-dd
force-pushed
the
nick.ripley/old-windows-for-go119
branch
from
b51fe50
to
33514ce
Compare
|
Manual dispatch with Manual dispatch with |
BenchmarksBenchmark execution time: 2023-10-04 14:58:01 Comparing candidate commit 33514ce in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
nsrip-dd
changed the title
darccio
approved these changes
Oct 4, 2023
darccio
pushed a commit
that referenced
this pull request
Oct 5, 2023
Use windows-2019 runner when testing Go 1.19, since the windows-2022 image has an incompatible C toolchain which breaks some of our tests. (cherry picked from commit b4cc9ed)
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use windows-2019 runner when testing Go 1.19, since the windows-2022 image
has an incompatible C toolchain which breaks some of our tests.
This is a known issue, fixed in Go 1.20: golang/go#51007
Motivation
Keep CI green for Go 1.19.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!