-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run tests with -shuffle=on #2265
Conversation
Motivated by #2263
BenchmarksBenchmark execution time: 2024-01-02 12:49:10 Comparing candidate commit 0f9f89a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
@felixge and @RomainMuller it looks like this PR passed the last time it was attempted. Do you want to make shuffling tests the default? I'm mostly adding this comment since it was marked stale, so we should either update and merge it, or abandon it. FWIW: I personally think this is useful to make it less likely to have tests accidentally depending on global state modified by other tests, but also don't think it is super important. |
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been open for 30 days with no activity. |
Motivated by #2263
Opening this to see if we can pass CI with this option after the PR above is merged. I suspect there will be more failures ...
What does this PR do?
Motivation
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!