profiler: remove PprofDiff #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We deprecated PprofDiff in v1.49.0, with a note that it would be removed in a future release. There is a low likelihood that any user actually depends on this, and at any rate we have had several releases during which time staticcheck/other linters could flag the deprecated function. Finally remove it and inline it into the one place it was used.
BenchmarksBenchmark execution time: 2023-10-16 09:07:55 Comparing candidate commit 8904dc9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 0 unstable metrics. |
|
Any reason this is a draft? |
felixge
approved these changes
Oct 15, 2023
Just habit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the deprecated
PprofDifffunction.Motivation
We deprecated PprofDiff in v1.49.0, with a note that it would be removed in a
future release (see #1806). There is a low likelihood that any user actually
depends on this, and at any rate we have had several releases during which time
staticcheck/other linters would have flaged the deprecated function.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!