Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/google.golang.org/grpc: isolate tests using an independent rig instance instead of a shared one #2278

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

darccio
Copy link
Contributor

@darccio darccio commented Oct 18, 2023

What does this PR do?

This PR avoids flaky tests in contrib/google.golang.org/grpc that were using a shared rig instance concurrently.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

…g instance instead of a shared one

(cherry picked from commit bbc77a4)
(cherry picked from commit 8a5def5)
@darccio darccio requested a review from a team as a code owner October 18, 2023 07:50
@darccio darccio requested a review from a team October 18, 2023 07:50
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 18, 2023
@pr-commenter
Copy link

pr-commenter bot commented Oct 18, 2023

Benchmarks

Benchmark execution time: 2023-10-23 08:58:11

Comparing candidate commit f495b11 in PR branch dario.castane/port-fix-appsec-tests with baseline commit 00055c7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@darccio darccio enabled auto-merge (squash) October 18, 2023 08:54
@darccio
Copy link
Contributor Author

darccio commented Oct 23, 2023

@Julio-Guerra Can you review this change? It was released as part of v1.56.0 but never merged into main.

@darccio darccio merged commit 9d39644 into main Nov 9, 2023
50 checks passed
@darccio darccio deleted the dario.castane/port-fix-appsec-tests branch November 9, 2023 11:27
@darccio darccio restored the dario.castane/port-fix-appsec-tests branch November 16, 2023 15:20
@darccio darccio deleted the dario.castane/port-fix-appsec-tests branch November 16, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants