contrib/net/http: honor WithHeaderTags in WrapHandler #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Header tags configuration was only being handled in ServeHTTP but not in WrapHandler. This adds the logic to handle header tags in WrapHandler as well.
sudolibre
commented
Oct 23, 2023
| @@ -85,8 +85,9 @@ func WrapHandler(h http.Handler, service, resource string, opts ...Option) http. | |||
| if r := cfg.resourceNamer(req); r != "" { | |||
| resc = r | |||
| } | |||
| so := make([]ddtrace.StartSpanOption, len(cfg.spanOpts)) | |||
| so := make([]ddtrace.StartSpanOption, len(cfg.spanOpts), len(cfg.spanOpts)+1) | |||
There was a problem hiding this comment.
This change essentially duplicates line 56-59 in ServeHTTP
5 tasks
darccio
approved these changes
Oct 30, 2023
|
I ran all tests in #2307. Good to go. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Header tags configuration was only being handled in ServeHTTP but not in WrapHandler. This adds the logic to handle header tags in WrapHandler as well.
Motivation
This allows leveraging WithHeaderTags when using WrapHandler
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!