Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec: update event rules 1.7.1 -> 1.8.0 #2292

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

eliottness
Copy link
Contributor

What does this PR do?

Update the recommended ruleset to its latest version

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness requested a review from a team as a code owner October 25, 2023 12:31
@eliottness
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 25, 2023

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. You can remove it from the waiting list with /remove command.

you can cancel this operation by commenting your pull request with /merge -c!

@dd-devflow
Copy link

dd-devflow bot commented Oct 25, 2023

🚂 MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 9m)

you can cancel this operation by commenting your pull request with /merge -c!

@pr-commenter
Copy link

pr-commenter bot commented Oct 25, 2023

Benchmarks

Benchmark execution time: 2023-10-25 12:45:33

Comparing candidate commit 8c052fb in PR branch eliott.bouhana/APPSEC-11819 with baseline commit 5f985bb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 0 unstable metrics.

@dd-mergequeue dd-mergequeue bot merged commit 1dd3dd4 into main Oct 25, 2023
346 checks passed
@dd-mergequeue dd-mergequeue bot deleted the eliott.bouhana/APPSEC-11819 branch October 25, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants