Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remoteconfig: make rc client a singleton #2297

Merged
merged 5 commits into from
Oct 27, 2023
Merged

remoteconfig: make rc client a singleton #2297

merged 5 commits into from
Oct 27, 2023

Conversation

ahmed-mez
Copy link
Contributor

@ahmed-mez ahmed-mez commented Oct 26, 2023 •
edited
Loading

What does this PR do?

AIT-8578
Make the remote config client a singleton. Tracing and profiling will then be able to use it in addition to ASM.

Motivation

It's a requirement to have a single shared instance of the remote config client per tracer.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ahmed-mez ahmed-mez changed the title rc: make rc client a singleton remoteconfig: make rc client a singleton Oct 26, 2023
@ahmed-mez ahmed-mez marked this pull request as ready for review October 26, 2023 10:52
@ahmed-mez ahmed-mez requested review from a team as code owners October 26, 2023 10:52
@pr-commenter
Copy link

pr-commenter bot commented Oct 26, 2023 •
edited
Loading

Benchmarks

Benchmark execution time: 2023-10-27 09:00:21

Comparing candidate commit 66c9c3d in PR branch ahmed/rc-refactor with baseline commit 0f643a9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

Hellzy
Hellzy reviewed Oct 26, 2023
View reviewed changes
internal/remoteconfig/remoteconfig.go Outdated Show resolved Hide resolved
internal/remoteconfig/remoteconfig.go Outdated Show resolved Hide resolved
internal/remoteconfig/remoteconfig.go Outdated Show resolved Hide resolved
@ahmed-mez ahmed-mez requested a review from Hellzy October 27, 2023 08:51
Hellzy
Hellzy approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@Hellzy Hellzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this 🙏

@ahmed-mez ahmed-mez removed the request for review from Julio-Guerra October 27, 2023 12:06
@ahmed-mez ahmed-mez merged commit 07629d8 into main Oct 27, 2023
344 checks passed
@ahmed-mez ahmed-mez deleted the ahmed/rc-refactor branch October 27, 2023 12:08
@darccio darccio restored the ahmed/rc-refactor branch November 16, 2023 09:31
@darccio darccio deleted the ahmed/rc-refactor branch November 16, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julio-Guerra Julio-Guerra Julio-Guerra left review comments

@Hellzy Hellzy Hellzy approved these changes

@dianashevchenko dianashevchenko dianashevchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahmed-mez @Julio-Guerra @Hellzy @dianashevchenko