ddtrace/opentelemetry: Introduced OTel name remapping #2337
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BenchmarksBenchmark execution time: 2023-11-13 15:35:46 Comparing candidate commit 99ab227 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 36 metrics, 2 unstable metrics. scenario:BenchmarkOTelApiWithCustomTags/otel_api-24
|
|
I rerun the test suit, including APM_TRACING_E2E_OTEL and failed tests in Parametric, with the system tests branch DataDog/system-tests#1804. All pass |
Co-authored-by: Kyle Nusbaum <kyle@datadog.com>
ddtrace/opentelemetry/span.go
Outdated
| for k, v := range s.attributes { | ||
| // if we find operation.name, | ||
| if k == operationNameKey || k == ext.SpanName { | ||
| // set it and keep track that it was set to ignore everything else | ||
| if name, ok := v.(string); ok { | ||
| s.attributes[ext.SpanName] = strings.ToLower(name) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Refactoring suggestion:
Similar to the Java pseudocode in the doc, you can just check for an operation.name attribute in the converter function, and return out early if it exists.
If you do that, then this entire loop can disappear.
i.e. the only changes you need in this entire function then are:
s.SetName(s.createOperationName())
for k, v := range s.attributes {
s.SetTag(k, v)
}
There was a problem hiding this comment.
Sorry, what do you mean by converter function ?
There was a problem hiding this comment.
By "converter function" I meant the createOperationName method you have.
What does this PR do?
This PR adds calculating of the operation name based on the OTel attributes and span kind.
Motivation
The OTel API only has the concept of a single name associated with a span, which in Datadog is represented as the “resource name”. However, Datadog has an additional name, the span’s “operation name”, which serves important functions such as metrics calculation, which is used for customer monitoring and alerting setups. Since the OTel API doesn’t have an equivalent for an operation name, we must calculate one.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!