contrib/google.golang.org/grpc: add hostname tag #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
apm:ecosystem
BenchmarksBenchmark execution time: 2023-12-11 13:30:02 Comparing candidate commit 862878a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
katiehockman
reviewed
Dec 1, 2023
Comment on lines
185
to
187
| if host, _, err := net.SplitHostPort(cc.Target()); err == nil { | ||
| span.SetTag(ext.PeerHostname, host) | ||
| } |
There was a problem hiding this comment.
Any way that cc could be nil? If so, this could panic.
There was a problem hiding this comment.
I don't think cc should be nil in any case where this code is being executed, but added a check just in case.
ahmed-mez
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
peer.hostnametag to the google.golang.org/grpc client integration containing the hostname of the server.Motivation
The existing
out.hosttag actually contains the resolved hostname, so its always an IP address. We want to have a separate tag that contains the actual hostname.Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!