Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{telemetry,remoteconfig}: support fraction of second intervals #2364

Merged
merged 1 commit into from Nov 17, 2023

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Support float values for DD_TELEMETRY_HEARTBEAT_INTERVAL and DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS

Motivation

These options are set to 0.2 in parametric tests to speed up the execution time.
https://github.com/DataDog/system-tests/blob/7cbb0153babff6b80cde7a6425ab41adcdffe014/tests/parametric/test_dynamic_configuration.py#L31-L32

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ahmed-mez ahmed-mez requested a review from a team as a code owner November 17, 2023 13:11
@ahmed-mez ahmed-mez changed the title {telemetr,remoteconfig}: support fraction of second intervals {telemetry,remoteconfig}: support fraction of second intervals Nov 17, 2023
@ahmed-mez ahmed-mez merged commit 33698d2 into main Nov 17, 2023
52 checks passed
@ahmed-mez ahmed-mez deleted the ahmed/float-intervals branch November 17, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants