Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtrace/opentelemetry,opentracing: fixed the format of telemetry tags #2367

Merged
merged 3 commits into from Nov 17, 2023
Merged

ddtrace/opentelemetry,opentracing: fixed the format of telemetry tags #2367

merged 3 commits into from Nov 17, 2023

Conversation

dianashevchenko
Copy link
Contributor

@dianashevchenko dianashevchenko commented Nov 17, 2023 •
edited

What does this PR do?

This PR fixes the format of telemetry tags in opentracing and opentelemetry packages. Previously, the string with integration_type had redundant quotes, which were causing the telemetry processing to not recognise the integration type and mark it as N/A.

Motivation

Missing metrics on the usage of opentelemetry package

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@dianashevchenko dianashevchenko changed the title test ddtrace/opentelemetry,opentracing: fixed the format of telemetry tags Nov 17, 2023
@dianashevchenko dianashevchenko marked this pull request as ready for review November 17, 2023 17:41
@dianashevchenko dianashevchenko requested a review from a team November 17, 2023 17:41
@dianashevchenko dianashevchenko requested a review from a team as a code owner November 17, 2023 17:41
@dianashevchenko dianashevchenko merged commit 70bc63c into main Nov 17, 2023
51 checks passed
@dianashevchenko dianashevchenko deleted the shevchenko/telemetry-bug branch November 17, 2023 17:56
Julio-Guerra added a commit that referenced this pull request Dec 20, 2023
@Julio-Guerra
ddtrace/opentelemetry,opentracing: fixed the format of telemetry tags #…
abcd40f 
…2367 (backport)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katiehockman katiehockman katiehockman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dianashevchenko @katiehockman