Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remoteconfig: add Subscribe function #2380

Merged
merged 1 commit into from
Nov 24, 2023
Merged

remoteconfig: add Subscribe function #2380

merged 1 commit into from
Nov 24, 2023

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Add a remote-config Subscribe function to register a product and its callback in a single call. This guarantees that the callback only receives updates for the corresponding product.

Motivation

Make the API more ergonomic and easier to use.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ahmed-mez ahmed-mez marked this pull request as ready for review November 24, 2023 10:21
@ahmed-mez ahmed-mez requested a review from a team November 24, 2023 10:21
@ahmed-mez ahmed-mez requested a review from a team as a code owner November 24, 2023 10:21
@pr-commenter
Copy link

pr-commenter bot commented Nov 24, 2023

Benchmarks

Benchmark execution time: 2023-11-24 12:01:27

Comparing candidate commit 37892ab in PR branch ahmed/rc-subscribe with baseline commit 8beb30d in branch main.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 36 metrics, 2 unstable metrics.

scenario:BenchmarkSingleSpanRetention/no-rules-24

  • 🟩 execution_time [-7.763µs; -6.715µs] or [-3.091%; -2.674%]

scenario:BenchmarkSingleSpanRetention/with-rules/match-all-24

  • 🟩 execution_time [-8.078µs; -5.931µs] or [-3.190%; -2.342%]

scenario:BenchmarkSingleSpanRetention/with-rules/match-half-24

  • 🟩 execution_time [-7.979µs; -6.071µs] or [-3.158%; -2.402%]

@ahmed-mez ahmed-mez merged commit 6a7dc15 into main Nov 24, 2023
51 checks passed
@ahmed-mez ahmed-mez deleted the ahmed/rc-subscribe branch November 24, 2023 12:14
katiehockman pushed a commit that referenced this pull request Nov 28, 2023
Fix related to #2380 : the RC client must report all registered products.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants