Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: Add example for running just one integration container #2429

Merged
merged 3 commits into from Dec 13, 2023

Conversation

ajgajg1134
Copy link
Contributor

@ajgajg1134 ajgajg1134 commented Dec 12, 2023

What does this PR do?

Adds a useful example for how to run a single container from our docker-compose

Motivation

This came in handy recently when I wanted to run just a single mysql unit test and didn't want to download / deal with the overhead of running every single container listed in our docker-compose

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ajgajg1134 ajgajg1134 marked this pull request as ready for review December 12, 2023 18:40
@ajgajg1134 ajgajg1134 requested a review from a team as a code owner December 12, 2023 18:40
@pr-commenter
Copy link

pr-commenter bot commented Dec 12, 2023

Benchmarks

Benchmark execution time: 2023-12-13 19:17:14

Comparing candidate commit 1a2aed1 in PR branch andrew.glaude/add-docker-example with baseline commit 417a56e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@ajgajg1134 ajgajg1134 merged commit eca84e5 into main Dec 13, 2023
54 checks passed
@ajgajg1134 ajgajg1134 deleted the andrew.glaude/add-docker-example branch December 13, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants