New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows: adapting last v2 CI changes #2435
Conversation
BenchmarksBenchmark execution time: 2023-12-21 19:52:22 Comparing candidate commit dd555d9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
905d392
to
2bdcf81
Compare
on: | ||
workflow_dispatch: # manually | ||
schedule: | ||
- cron: "0 0 * * *" | ||
|
||
jobs: | ||
appsec-v2: | ||
uses: ./.github/workflows/appsec.yml | ||
uses: DataDog/dd-trace-go/.github/workflows/appsec.yml@v2-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes them tremendously painful to update (since it needs to be on the branch before it can be tested); but unfortunately GitHub offers no better way...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fond of this too, but you said it: GitHub offers no better way. Thanks for the approval!
What does this PR do?
Cleans up
main
CI, removing v2 stuff. Everything now lives inv2-dev
, invoked from thev2-nightly.yml
.Motivation
Simplify CI removing v2 details from
main
.Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!