Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: adapting last v2 CI changes #2435

Merged
merged 11 commits into from Dec 22, 2023

Conversation

darccio
Copy link
Contributor

@darccio darccio commented Dec 14, 2023

What does this PR do?

Cleans up main CI, removing v2 stuff. Everything now lives in v2-dev, invoked from the v2-nightly.yml.

Motivation

Simplify CI removing v2 details from main.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Dec 14, 2023

Benchmarks

Benchmark execution time: 2023-12-21 19:52:22

Comparing candidate commit dd555d9 in PR branch dario.castane/cherrypick-v2-ci with baseline commit 82f5b7e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@darccio darccio force-pushed the dario.castane/cherrypick-v2-ci branch from 905d392 to 2bdcf81 Compare December 21, 2023 12:07
@darccio darccio marked this pull request as ready for review December 21, 2023 17:40
@darccio darccio requested review from a team as code owners December 21, 2023 17:40
on:
workflow_dispatch: # manually
schedule:
- cron: "0 0 * * *"

jobs:
appsec-v2:
uses: ./.github/workflows/appsec.yml
uses: DataDog/dd-trace-go/.github/workflows/appsec.yml@v2-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes them tremendously painful to update (since it needs to be on the branch before it can be tested); but unfortunately GitHub offers no better way...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fond of this too, but you said it: GitHub offers no better way. Thanks for the approval!

@darccio darccio enabled auto-merge (squash) December 22, 2023 16:03
auto-merge was automatically disabled December 22, 2023 16:07

Pull Request is not mergeable

@darccio darccio merged commit 953795b into main Dec 22, 2023
334 checks passed
@darccio darccio deleted the dario.castane/cherrypick-v2-ci branch December 22, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants