Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system-tests: add the uds-echo variant #2438

Merged
merged 1 commit into from Dec 15, 2023

Conversation

Julio-Guerra
Copy link
Contributor

@Julio-Guerra Julio-Guerra commented Dec 15, 2023

What does this PR do?

Add the missing usd-echo weblog variant.

Motivation

Better coverage - especially on the fact this variant is failing.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Dec 15, 2023

Benchmarks

Benchmark execution time: 2023-12-15 09:40:36

Comparing candidate commit 9b8233e in PR branch julio.guerra/system-tests-uds-echo with baseline commit 5a92f7b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@Julio-Guerra Julio-Guerra marked this pull request as ready for review December 15, 2023 11:33
@Julio-Guerra Julio-Guerra requested a review from a team as a code owner December 15, 2023 11:33
@Julio-Guerra Julio-Guerra merged commit 39c764b into main Dec 15, 2023
64 checks passed
@Julio-Guerra Julio-Guerra deleted the julio.guerra/system-tests-uds-echo branch December 15, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants