Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtracer/tracer: fix flaky TestReportHealthMetrics on Windows #2439

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

darccio
Copy link
Contributor

@darccio darccio commented Dec 15, 2023

What does this PR do?

Modifies testStatsdClient to fix flakiness in TestReportHealthMetrics when running on Windows.

Motivation

Keep CI green, and reduce the feedback loop.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@darccio darccio force-pushed the dario.castane/fix-flaky-testreporthealthmetrics-win branch from 3e16f34 to 2dfa247 Compare December 15, 2023 10:41
@darccio darccio closed this Dec 15, 2023
@darccio darccio force-pushed the dario.castane/fix-flaky-testreporthealthmetrics-win branch from 2dfa247 to 5a92f7b Compare December 15, 2023 10:43
@darccio darccio reopened this Dec 15, 2023
@darccio darccio force-pushed the dario.castane/fix-flaky-testreporthealthmetrics-win branch from ea3dc2b to 4be3684 Compare December 15, 2023 11:06
@pr-commenter
Copy link

pr-commenter bot commented Dec 15, 2023

Benchmarks

Benchmark execution time: 2023-12-18 16:05:32

Comparing candidate commit 6df90fe in PR branch dario.castane/fix-flaky-testreporthealthmetrics-win with baseline commit f0a65c0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@darccio darccio marked this pull request as ready for review December 15, 2023 11:33
@darccio darccio requested a review from a team December 15, 2023 11:33
@darccio darccio enabled auto-merge (squash) December 18, 2023 15:51
auto-merge was automatically disabled December 18, 2023 15:54

Pull Request is not mergeable

@darccio darccio enabled auto-merge (squash) December 21, 2023 11:45
@darccio darccio merged commit 8ca9351 into main Dec 21, 2023
153 checks passed
@darccio darccio deleted the dario.castane/fix-flaky-testreporthealthmetrics-win branch December 21, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants