Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maitenance: new GitHub Triage Badger #2451

Merged
merged 2 commits into from Dec 21, 2023

Conversation

RomainMuller
Copy link
Contributor

What does this PR do?

Adds a new GitHub workflow which automatically adds a needs-triage label to issues that are opened or re-opened, which is to be removed whenever triage is performed.

Every weekday (at 8am UTC, per the current configuration), the workflow lists up to 10 issues that have the needs-triage label and are more than 3 days old, and sends messages to Slack via a configrued WebHook to pester maintainers to triage them. The Slack message includes a link to the issue as well as the issue's ID, title, body, and creation timestamp.

Motivation

Per the last guild meeting, we agreed it would be helpful to have some automation help us make sure new issues are looked at at least in a cursory manner, so we (for example) catch sensitive content (which should not be in GitHub issues) earlier rather than later.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Adds a new GitHub workflow which automatically adds a `needs-triage`
label to issues that are opened or re-opened, which is to be removed
whenever triage is performed.

Every weekday (at 8am UTC, per the current configuration), the workflow
lists up to 10 issues that have the `needs-triage` label and are more
than 3 days old, and sends messages to Slack via a configrued WebHook to
pester maintainers to triage them. The Slack message includes a link to
the issue as well as the issue's ID, title, body, and creation
timestamp.
@RomainMuller RomainMuller requested a review from a team as a code owner December 19, 2023 16:25
@RomainMuller
Copy link
Contributor Author

This is an example of what it looks like in Slack today (the current WebHook will message me directly; I will switch this to an agreed upon channel once we agree on the details).

Capture d’écran 2023-12-19 à 17 26 12

@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2023

Benchmarks

Benchmark execution time: 2023-12-20 17:42:41

Comparing candidate commit fecab5a in PR branch romain.marcadier/triage-workflow with baseline commit 3dfd935 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@RomainMuller RomainMuller enabled auto-merge (squash) December 20, 2023 17:26
auto-merge was automatically disabled December 20, 2023 17:29

Pull Request is not mergeable

@RomainMuller RomainMuller merged commit e592b5c into main Dec 21, 2023
153 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/triage-workflow branch December 21, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants