Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: only listen on localhost in TestTransportResponse #2463

Merged
merged 2 commits into from Dec 21, 2023

Conversation

nsrip-dd
Copy link
Contributor

@nsrip-dd nsrip-dd commented Dec 21, 2023

What does this PR do?

Listen on localhost in TestTransportResponse

Motivation

Screenshot 2023-12-21 at 9 18 47 AM

If we pass net.Listen an empty host, we'll listen on all available
addresses. macOS will warn about the app accepting incoming network
connections if we do this, creating an annoying popup each time we run
the whole tracer test suite. Using localhost is sufficient for this
test.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

If we pass net.Listen an empty host, we'll listen on all available
addresses. macOS will warn about the app accepting incoming network
connections if we do this, creating an annoying popup each time we run
the whole tracer test suite. Using localhost is sufficient for this
test.
@nsrip-dd nsrip-dd requested a review from a team December 21, 2023 14:31
@pr-commenter
Copy link

pr-commenter bot commented Dec 21, 2023

Benchmarks

Benchmark execution time: 2023-12-21 14:46:59

Comparing candidate commit 7d19826 in PR branch nick.ripley/tracer-test-localhost-only with baseline commit a5129ef in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@darccio
Copy link
Contributor

darccio commented Dec 21, 2023

Yeah, good catch!

@nsrip-dd nsrip-dd enabled auto-merge (squash) December 21, 2023 15:26
@nsrip-dd nsrip-dd merged commit fe30a71 into main Dec 21, 2023
153 checks passed
@nsrip-dd nsrip-dd deleted the nick.ripley/tracer-test-localhost-only branch December 21, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants