Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracer: handle rc deletion in dynamic config #2468

Merged
merged 1 commit into from Dec 27, 2023

Conversation

ahmed-mez
Copy link
Contributor

@ahmed-mez ahmed-mez commented Dec 26, 2023

What does this PR do?

AIT-9257

Handle RC deletion in dynamic configuration by reapplying the original configuration values.

The remote-config client signals a config deletion by sending a nil content as documented here

// Set the payload data to nil for missing config files. The callbacks then can handle the nil config case to detect
// that this config will not be updated anymore.

Motivation

Bug fix.

In addition to the unit test, this fix has been validated e2e manually and a parametric test case will be added in the future.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ahmed-mez ahmed-mez requested a review from a team December 26, 2023 12:04
@pr-commenter
Copy link

pr-commenter bot commented Dec 26, 2023

Benchmarks

Benchmark execution time: 2023-12-27 09:19:50

Comparing candidate commit 67e0c5a in PR branch ahmed/handle-rc-deletion with baseline commit f986cc5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@ahmed-mez ahmed-mez marked this pull request as ready for review December 27, 2023 09:04
@ahmed-mez
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 27, 2023

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

you can cancel this operation by commenting your pull request with /merge -c!

@dd-devflow
Copy link

dd-devflow bot commented Dec 27, 2023

🚂 MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 0s)

you can cancel this operation by commenting your pull request with /merge -c!

@dd-mergequeue dd-mergequeue bot merged commit cb699a6 into main Dec 27, 2023
155 checks passed
@dd-mergequeue dd-mergequeue bot deleted the ahmed/handle-rc-deletion branch December 27, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants