Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: simplified SpanTagsResourceRule #2470

Conversation

dianashevchenko
Copy link
Contributor

What does this PR do?

Updates SpanTagsResourceRule according to the comment left on main feature branch.
Additionally, updates the MarshalJSON function with the new fields.

Motivation

Simplify UX.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@dianashevchenko dianashevchenko requested a review from a team December 28, 2023 11:36
@pr-commenter
Copy link

pr-commenter bot commented Dec 28, 2023

Benchmarks

Benchmark execution time: 2023-12-28 12:15:04

Comparing candidate commit 44b0590 in PR branch shevchenko/simplify-sampling-option with baseline commit 5d50d35 in branch shevchenko/tag-resource-sampling.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@dianashevchenko dianashevchenko merged commit c89ec56 into shevchenko/tag-resource-sampling Jan 3, 2024
151 checks passed
@dianashevchenko dianashevchenko deleted the shevchenko/simplify-sampling-option branch January 3, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants