Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODEOWNERS: Update for new gh team structure #2477

Merged
merged 1 commit into from Jan 4, 2024
Merged

CODEOWNERS: Update for new gh team structure #2477

merged 1 commit into from Jan 4, 2024

Conversation

felixge
Copy link
Member

@felixge felixge commented Jan 4, 2024 •
edited

What does this PR do? / Motivation

See PROF-8847

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

felixge
felixge commented Jan 4, 2024
View reviewed changes
CODEOWNERS

# linter rules
.golangci.yml @DataDog/tracing-go @DataDog/profiling-go @DataDog/asm-go

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I've removed the rules for telemetry and linter because they are covered by the default owner rule on top.

@felixge felixge marked this pull request as ready for review January 4, 2024 09:38
@felixge felixge requested a review from a team as a code owner January 4, 2024 09:39
@felixge felixge enabled auto-merge (squash) January 4, 2024 09:41
@felixge felixge merged commit 1a89fe9 into main Jan 4, 2024
154 of 155 checks passed
@felixge felixge deleted the felix.geisendoerfer/PROF-8847-update-codeowners branch January 4, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darccio darccio darccio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixge @darccio