Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracer/log: Add feature flags to startup logs #2495

Merged
merged 4 commits into from Jan 10, 2024

Conversation

ajgajg1134
Copy link
Contributor

What does this PR do?

Add feature flags to startup logs

Motivation

Makes it easier to identify if a service has a feature flag enabled like "discovery" which can be used to enable client side stats calculation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ajgajg1134 ajgajg1134 marked this pull request as ready for review January 9, 2024 20:28
@ajgajg1134 ajgajg1134 requested a review from a team as a code owner January 9, 2024 20:28
ddtrace/tracer/log.go Outdated Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Jan 9, 2024

Benchmarks

Benchmark execution time: 2024-01-09 21:25:42

Comparing candidate commit bca9cf7 in PR branch andrew.glaude/FeatureFlagsLog with baseline commit 249640f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

ddtrace/tracer/log.go Outdated Show resolved Hide resolved
@katiehockman katiehockman enabled auto-merge (squash) January 10, 2024 19:42
@katiehockman katiehockman merged commit c4af999 into main Jan 10, 2024
153 of 154 checks passed
@katiehockman katiehockman deleted the andrew.glaude/FeatureFlagsLog branch January 10, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants