Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: generalize GH workflow for adding apm:ecosystems label #2496

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

katiehockman
Copy link
Contributor

What does this PR do?

Removes the condition on PR/issue title, and instead always applies the apm:ecosytem label to all PRs and issues that are in a contrib directory. This will also ensure that PRs created by dependabot will have this labe.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@katiehockman katiehockman marked this pull request as ready for review January 9, 2024 21:39
@katiehockman katiehockman requested a review from a team as a code owner January 9, 2024 21:39
@pr-commenter
Copy link

pr-commenter bot commented Jan 9, 2024

Benchmarks

Benchmark execution time: 2024-01-09 21:55:14

Comparing candidate commit 9bdec0f in PR branch katie.hockman/dependabot with baseline commit 249640f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@katiehockman katiehockman enabled auto-merge (squash) January 10, 2024 15:55
@katiehockman katiehockman merged commit 2ba2e8b into main Jan 10, 2024
153 of 154 checks passed
@katiehockman katiehockman deleted the katie.hockman/dependabot branch January 10, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants