Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remoteconfig: remove mutex underscore prefixes #2497

Merged
merged 2 commits into from Jan 10, 2024

Conversation

Hellzy
Copy link
Contributor

@Hellzy Hellzy commented Jan 10, 2024

What does this PR do?

This renames the mutexes variables in remoteconfig.go to get rid of their underscored prefixes

Motivation

Keeping our code better aligned with common Go practices.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@Hellzy Hellzy requested a review from a team as a code owner January 10, 2024 10:31
@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2024

Benchmarks

Benchmark execution time: 2024-01-10 11:34:19

Comparing candidate commit 3d64ffe in PR branch francois.mazeau/rc-client-renaming with baseline commit abe0073 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜

@Hellzy Hellzy merged commit fa1f71f into main Jan 10, 2024
154 checks passed
@Hellzy Hellzy deleted the francois.mazeau/rc-client-renaming branch January 10, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants