Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/telemetry: remove DetectLibDl #2517

Merged
merged 2 commits into from Jan 18, 2024
Merged

Conversation

katiehockman
Copy link
Contributor

What does this PR do?

Removes liddl detection within the Go telemetry client.

Motivation

See #2516

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@katiehockman katiehockman marked this pull request as ready for review January 17, 2024 18:18
@katiehockman katiehockman requested review from a team as code owners January 17, 2024 18:18
@katiehockman katiehockman requested a review from a team as a code owner January 17, 2024 18:30
@pr-commenter
Copy link

pr-commenter bot commented Jan 17, 2024

Benchmarks

Benchmark execution time: 2024-01-17 18:45:55

Comparing candidate commit 8c10e5f in PR branch katie.hockman/revert-detectlibdl with baseline commit fe06fbb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@katiehockman
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 17, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

you can cancel this operation by commenting your pull request with /merge -c!

@dd-devflow
Copy link

dd-devflow bot commented Jan 18, 2024

⚠️ MergeQueue

This merge request was unqueued

If you need support, contact us on slack #ci-interfaces!

@darccio darccio merged commit 9f088b5 into main Jan 18, 2024
334 of 336 checks passed
@darccio darccio deleted the katie.hockman/revert-detectlibdl branch January 18, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants