Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade purego v0.5.0 => upgrade purego v0.5.2 #2524

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

eliottness
Copy link
Contributor

What does this PR do?

go get github.com/ebitengine/purego@v0.5.2

Motivation

get ebitengine/purego#189 fix from upstream

Fixes #2504

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness self-assigned this Jan 22, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2024

Benchmarks

Benchmark execution time: 2024-01-22 12:23:20

Comparing candidate commit aefe1bf in PR branch eliott.bouhana/upgrade-purego with baseline commit 882cddb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@eliottness eliottness requested a review from a team as a code owner January 22, 2024 11:14
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
internal/apps/go.mod Show resolved Hide resolved
@eliottness eliottness merged commit b5e5225 into main Jan 22, 2024
154 checks passed
@eliottness eliottness deleted the eliott.bouhana/upgrade-purego branch January 22, 2024 15:44
katiehockman pushed a commit that referenced this pull request Jan 22, 2024
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] go build errors after upgrading to 1.59.0
2 participants