Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiler: skip flaky TestExecutionTraceRandom #2531

Merged
merged 1 commit into from Jan 29, 2024

Conversation

nsrip-dd
Copy link
Contributor

What does this PR do?

Skips TestExecutionTraceRandom, which is flaky, following our flaky test policy.

Motivation

This test is failing more often than we'd like. Skip it for now until we can
pick more reasonable bounds (or, a better way to test this in general)

Updates #2529

This test is failing more often than we'd like. Skip it for now until we
can pick more reasonable bounds (or, a better way to test this in
general)

Updates #2529
@nsrip-dd nsrip-dd requested a review from a team as a code owner January 29, 2024 17:54
@pr-commenter
Copy link

pr-commenter bot commented Jan 29, 2024

Benchmarks

Benchmark execution time: 2024-01-29 18:09:55

Comparing candidate commit c783abc in PR branch nick.ripley/skip-flaky-profiler-test with baseline commit a3176e0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@felixge felixge merged commit e34ca9b into main Jan 29, 2024
154 checks passed
@felixge felixge deleted the nick.ripley/skip-flaky-profiler-test branch January 29, 2024 21:19
darccio added a commit that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants