Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix smoke test workflow_call situation #2547

Merged
merged 1 commit into from Feb 8, 2024

Conversation

RomainMuller
Copy link
Contributor

What does this PR do?

The default repository being checked out by actions/checkout is the one designated by ${{ github.repository }}, which is the repository where the original event (at the root of the workflow call tree) started.

We however must check out the source to dd-trace-go and not that of the caller workflow. This requires hard-coding the repository name here.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

The default repository being checked out by `actions/checkout` is the
one designated by `${{ github.repository }}`, which is the repository
where the original event (at the root of the workflow call tree)
started.

We however must check out the source to `dd-trace-go` and not that of
the caller workflow. This requires hard-coding the repository name here.
@RomainMuller RomainMuller requested a review from a team as a code owner February 8, 2024 13:51
@pr-commenter
Copy link

pr-commenter bot commented Feb 8, 2024

Benchmarks

Benchmark execution time: 2024-02-08 14:06:04

Comparing candidate commit dcdff83 in PR branch romain.marcadier/reusable-smoke-test with baseline commit c4eae21 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@RomainMuller RomainMuller enabled auto-merge (squash) February 8, 2024 14:23
@RomainMuller RomainMuller merged commit 4729158 into main Feb 8, 2024
154 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/reusable-smoke-test branch February 8, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants