Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: remove inet.af/netaddr dependency #2553

Merged
merged 2 commits into from Feb 13, 2024

Conversation

darccio
Copy link
Contributor

@darccio darccio commented Feb 13, 2024

What does this PR do?

Removes inet.af/netaddr, upgrading github.com/DataDog/appsec-internal-go
(that removes the usage of inet.af/netaddr in DataDog/appsec-internal-go#21).

Motivation

This is needed because of the domain takedown by the Afghan government on several domains. Fixes #2552.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2024

Benchmarks

Benchmark execution time: 2024-02-13 08:33:25

Comparing candidate commit d5dce2a in PR branch dario.castane/AIT-9795/inetaf-takedown with baseline commit c95c5e7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@darccio darccio marked this pull request as ready for review February 13, 2024 08:26
@darccio darccio changed the title go.mod: replace inet.af/netaddr with go4.org/netipx go.mod: replace inet.af/netaddr dependency Feb 13, 2024
@darccio darccio changed the title go.mod: replace inet.af/netaddr dependency go.mod: remove inet.af/netaddr dependency Feb 13, 2024
@darccio darccio enabled auto-merge (squash) February 13, 2024 08:31
@darccio darccio requested a review from a team February 13, 2024 08:39
@darccio darccio merged commit a9ee5d9 into main Feb 13, 2024
154 checks passed
@darccio darccio deleted the dario.castane/AIT-9795/inetaf-takedown branch February 13, 2024 08:40
@eliottness eliottness mentioned this pull request Feb 13, 2024
8 tasks
@mraerino
Copy link

any idea when this is going to be part of a release?

@darccio
Copy link
Contributor Author

darccio commented Feb 13, 2024

@mraerino We are working on an expedited release. Does the workaround work for you?

@mraerino
Copy link

yeah, i think we'll be able to work around, just wanted to make sure when i can expect to properly fix this without a workaround

@darccio
Copy link
Contributor Author

darccio commented Feb 13, 2024

@mraerino Released as v1.60.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Unable to import tracer package
3 participants