New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: remove inet.af/netaddr dependency #2553
Conversation
BenchmarksBenchmark execution time: 2024-02-13 08:33:25 Comparing candidate commit d5dce2a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
Removes dependency with inet.af/netaddr
any idea when this is going to be part of a release? |
@mraerino We are working on an expedited release. Does the workaround work for you? |
yeah, i think we'll be able to work around, just wanted to make sure when i can expect to properly fix this without a workaround |
What does this PR do?
Removes
inet.af/netaddr
, upgradinggithub.com/DataDog/appsec-internal-go
(that removes the usage of
inet.af/netaddr
in DataDog/appsec-internal-go#21).Motivation
This is needed because of the domain takedown by the Afghan government on several domains. Fixes #2552.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!