Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/gorm.io/gorm.v1: do not panic on open #2560

Merged
merged 2 commits into from Feb 21, 2024

Conversation

bendiknesbo
Copy link
Contributor

If passing a nil *gorm.Config to Open, we should not panic, but instead pass nothing on to gorm.

Fixes #2559

What does this PR do?

This PR fixes a panic when calling Open with a nil-config.
Calling the original gorm library with a nil-config is valid (although no-op),
so we should mimic that behavior in dd-trace-go.

Motivation

Fixes #2559

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

If passing a nil `*gorm.Config` to `Open`, we should not panic, but instead
pass nothing on to `gorm`.

Fixes DataDog#2559
@bendiknesbo bendiknesbo requested a review from a team as a code owner February 14, 2024 12:47
@darccio darccio added the apm:ecosystem contrib/* related feature requests or bugs label Feb 21, 2024
@darccio darccio merged commit 1dfe613 into DataDog:main Feb 21, 2024
100 checks passed
@bendiknesbo bendiknesbo deleted the contrib-fix-gorm-open-panic branch February 21, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Panic in contrib/gorm.io/gorm.v1
2 participants