contrib/gorm.io/gorm.v1: do not panic on open #2560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If passing a nil
*gorm.Config
toOpen
, we should not panic, but instead pass nothing on togorm
.Fixes #2559
What does this PR do?
This PR fixes a panic when calling
Open
with a nil-config.Calling the original
gorm
library with a nil-config is valid (although no-op),so we should mimic that behavior in dd-trace-go.
Motivation
Fixes #2559
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!