ddtrace/tracer: removed appsec.enabled assertion in RC test #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darccio
approved these changes
Feb 15, 2024
felixge
reviewed
Feb 20, 2024
| @@ -8,10 +8,10 @@ require ( | |||
| ) | |||
|
|
|||
| require ( | |||
| github.com/DataDog/appsec-internal-go v1.4.0 // indirect | |||
| github.com/DataDog/go-libddwaf/v2 v2.2.3 // indirect | |||
| github.com/DataDog/appsec-internal-go v1.4.1 // indirect | |||
There was a problem hiding this comment.
Why was this change made as part of this PR? Was it needed? I'm asking because I need to decide whether to backport this change into my v1.61.0 release branch to get the CI checks to pass.
If this change was not needed, maybe you could approve this PR? 🙇
There was a problem hiding this comment.
Update: I made a mistake while looking at this. I thought it was the main go.mod file, not the internal/apps/go.mod file. So this change doesn't matter, and I didn't need to revert it in #2567.
It's all good, but sorry for the noise.
felixge
pushed a commit
that referenced
this pull request
Feb 20, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove faulty appsec.Enabled() assertion in RC tests, which always fails on windows machines.
Motivation
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!