Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/gofiber/fiber.v2: add possibility to exclude spans generation for specific requests #2583

Merged
merged 3 commits into from Mar 5, 2024

Conversation

nsakharenko
Copy link
Contributor

What does this PR do?

Thi PR is about adding functionality to gofiber trace Middleware to avoid span generation for a specific requests.

Motivation

Exclude spans generation for unneeded endpoints, like /healthcheck, /, /version etc. and to be able to do it on an application level rather than DD Agent.

Issue

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@nsakharenko nsakharenko requested a review from a team as a code owner February 28, 2024 12:43
@nsakharenko nsakharenko changed the title contrib/gofiber/fiber.v2: possibility to exclude spans generation for specific requests contrib/gofiber/fiber.v2: add possibility to exclude spans generation for specific requests Feb 28, 2024
Copy link
Contributor

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darccio darccio requested a review from a team March 4, 2024 11:04
@darccio darccio added the apm:ecosystem contrib/* related feature requests or bugs label Mar 4, 2024
Copy link
Contributor

@rarguelloF rarguelloF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darccio darccio merged commit 47f3303 into DataDog:main Mar 5, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants