Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/google.golang.org/grpc: security rule passlist support #2589

Merged
merged 3 commits into from Mar 4, 2024

Conversation

Julio-Guerra
Copy link
Contributor

@Julio-Guerra Julio-Guerra commented Feb 29, 2024

What does this PR do?

Implement the grpc.server.method security rule address.
Tested with a custom ruleset passlist.json.

Motivation

AppSec Passlist Support for gRPC, where a gRPC security rule can be passlisted according to the gRPC method name.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

APPSEC-52066

@Julio-Guerra Julio-Guerra requested review from a team as code owners February 29, 2024 21:52
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Feb 29, 2024
@Julio-Guerra Julio-Guerra enabled auto-merge (squash) February 29, 2024 21:56
@pr-commenter
Copy link

pr-commenter bot commented Feb 29, 2024

Benchmarks

Benchmark execution time: 2024-03-01 09:45:39

Comparing candidate commit 5d89b19 in PR branch julio.guerra/grpc-passlisting with baseline commit 35aa850 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

contrib/google.golang.org/grpc/appsec_test.go Show resolved Hide resolved
internal/appsec/listener/grpcsec/grpc.go Show resolved Hide resolved
internal/appsec/listener/grpcsec/grpc.go Outdated Show resolved Hide resolved
Co-authored-by: Romain Marcadier <romain@datadoghq.com>
@Julio-Guerra Julio-Guerra merged commit cb92842 into main Mar 4, 2024
188 of 191 checks passed
@Julio-Guerra Julio-Guerra deleted the julio.guerra/grpc-passlisting branch March 4, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs appsec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants