Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-libddwaf: v2.3.1 -> v2.3.2 & appsec-internal-go: v1.4.2 -> v1.5.0 #2591

Merged
merged 3 commits into from Mar 5, 2024

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Mar 4, 2024

What does this PR do?

Upgrade appsec dependencies. Major changes:

  • The WAF now ignores byte slices are they are slowing down appsec and generation a lot of false positives, especially json.RawMessage
  • Upgrade static rules to v1.11.0
  • Switch DD_APPSEC_WAF_TIMEOUT default values from 4ms to 1ms

This PR runs go mod tidy in dd-trace-go root and in internal/apps/

Motivation

Better customer experience

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@pr-commenter
Copy link

pr-commenter bot commented Mar 4, 2024

Benchmarks

Benchmark execution time: 2024-03-04 16:41:17

Comparing candidate commit b712949 in PR branch eliott.bouhana/appsec-deps-update with baseline commit cb92842 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@eliottness eliottness requested a review from a team as a code owner March 4, 2024 16:20
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness force-pushed the eliott.bouhana/appsec-deps-update branch from 73d4433 to b712949 Compare March 4, 2024 16:26
@@ -2152,6 +2152,7 @@ go.uber.org/atomic v1.11.0 h1:ZvwS0R+56ePWxUNi+Atn9dWONBPp/AUETXlHW0DxSjE=
go.uber.org/atomic v1.11.0/go.mod h1:LUxbIzbOniOlMKjJjyPfpl4v+PKK2cNJn91OQbhoJI0=
go.uber.org/goleak v1.1.10/go.mod h1:8a7PlsEVH3e/a/GLqe5IIrQx6GzcnRmZEufDUTk4A7A=
go.uber.org/goleak v1.1.12/go.mod h1:cwTWslyiVhfpKIDGSZEM2HlOvcqm+tG4zioyIeLoqMQ=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like go mod tidy hasn't been run for a while (duplicated module entries for different versions) - can you please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did run go mod tidy in this PR but I guess someone added some stuff on the main branch without running go mod tidy during that time. Now its merged, sorry I did not see this sooner 😢

@eliottness eliottness enabled auto-merge (squash) March 5, 2024 12:40
@eliottness eliottness merged commit e174e40 into main Mar 5, 2024
190 of 191 checks passed
@eliottness eliottness deleted the eliott.bouhana/appsec-deps-update branch March 5, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants