Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: fix sampling rule override for manual keep #2666

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

dianashevchenko
Copy link
Contributor

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Apr 19, 2024

Benchmarks

Benchmark execution time: 2024-04-19 13:32:45

Comparing candidate commit fa9237d in PR branch shevchenko/manual-keep-bug with baseline commit fda4cc5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 1 unstable metrics.

@dianashevchenko dianashevchenko marked this pull request as ready for review April 22, 2024 13:12
@dianashevchenko dianashevchenko requested a review from a team as a code owner April 22, 2024 13:12
@dianashevchenko dianashevchenko enabled auto-merge (squash) April 22, 2024 15:02
@dianashevchenko dianashevchenko merged commit c4f2942 into main Apr 22, 2024
157 of 158 checks passed
@dianashevchenko dianashevchenko deleted the shevchenko/manual-keep-bug branch April 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants