contrib: Fixing Span Types for Redis, ElasticSearch, and Cassandra #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 26, 2018 15:44
|
Code looks good, but I'm not sure on the meaning of span types |
palazzem
approved these changes
Jul 27, 2018
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
…ataDog#282) * contrib/garyburd/redigo: Changing Span Type to `redis` * contrib/go-redis/redis: Changing the Span Type to `redis` * contrib/gocql/gocql: Changing the Span Type to `cassandra` * contrib/olivere/elastic: Changing the span type to `elasticsearch` * contrib/garyburd/redigo: Fix the expected span type in a unit test. * contrib/go-redis/redis: Fixed expected Span Type in tests. * contrib/go-redis/redis: Changing the span type in the example. * ddtrace/ext: added a constant for HTTP span types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All database integrations were using
dbfor the SpanType. Redis, ElasticSearch, and Cassandra were all updated to use their respective Span Types.I also verified that the web frameworks were using the correct Span Type (
web).