contrib/Shopify/sarama: add support for tracing the sarama kafka package #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd-caleb
added
apm:ecosystem
|
Looks like there are some issues with the tests. I also forgot to allow customizing the service name. Working on that now. |
gbbr
suggested changes
Sep 13, 2018
|
I think this is related to recent changes in the upstream library. I will fix the tests. |
|
The issue was caused by attempting to add a metadata header to the kafka producer message payload which is only supported in versions >= 0.11. The default protocol version is 0.8.2, so that explains why the test broke. I added code to only add the header if the version is at least 0.11. |
|
Nice! Thanks for making these changes. CI is still failing though... :-/ |
|
@gbbr I updated the test to match the example and it passed this time: https://github.com/Shopify/sarama/blob/46cf3e2cf1acef7876068f66cf69ec31aad2d0b2/sync_producer_test.go#L57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #295
This PR implements wrappers for
Consumer,SyncProducerandAsyncProducer. It also implements carriers forProducerMessageandConsumerMessageso that span contexts can be injected and extracted.I modeled the naming and behavior after our dd-trace-java integration.