ddtrace/ext: add additional tags for peers and databases #300
Conversation
dd-caleb
added
apm:ecosystem
There was a problem hiding this comment.
My intention with this package was to keep constants pointing to keys and values that have special (or standardized) meaning at Datadog. I was hoping it would be a place where users could go for documentation and to learn more about various significant tags.
The constants in this PR are not used by us nor are they standard and I feel keeping them will create extra noise and confusion. Unless we're planning to make these standard, I'd remove them. We can (and should IMHO) keep only db.user and db.application which we do seem to automatically use with SQL integrations.
|
I'm not familiar with the standards. I copied them from Java open-tracing, which we used in dd-trace-java. I will remove all but |
contrib/database/sql/sql_test.go
Outdated
| @@ -44,7 +44,7 @@ func TestMySQL(t *testing.T) { | |||
| ext.SpanType: ext.SpanTypeSQL, | |||
| ext.TargetHost: "127.0.0.1", | |||
| ext.TargetPort: "3306", | |||
| "db.user": "test", | |||
| ext.DBUser: "test", | |||
| "db.name": "test", | |||
There was a problem hiding this comment.
While we're at it... Should we add this one too? Seems only logical.
This pulls out the
extchanges from: #294 and uses them in database/sql.