contrib/net/http: add a convenience WrapClient method #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will facilitate integrating with libraries such as `go-github` and `go-cloud`
bmermet
reviewed
Sep 19, 2018
| // WrapClient modifies the given client's transport to augment it with tracing and returns it. | ||
| func WrapClient(c *http.Client, opts ...RoundTripperOption) *http.Client { | ||
| if c.Transport == nil { | ||
| c.Transport = http.DefaultTransport |
There was a problem hiding this comment.
Is http.DefaultTransport automatically wrapped?
There was a problem hiding this comment.
I'm not 100% sure I understand the question. If you're wondering if calling WrapClient will accidentally wrap the default transport, the answer is no.
There was a problem hiding this comment.
Indeed, I misread the code. My question doesn't make much sense.
Everything looks good 👍
dd-caleb
approved these changes
Sep 19, 2018
|
@dd-caleb good idea, check the latest commit - that's what you mean, right? |
|
@gbbr yep, thanks. Should hopefully prevent double tracing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will facilitate integrating with libraries such as
go-github