Allow custom SpansBuffer max size #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LotharSee
approved these changes
Feb 13, 2017
|
closed in favor of #37 |
jdgordon
pushed a commit
to jdgordon/dd-trace-go
that referenced
this pull request
May 31, 2022
Add distribution type for percentile sketches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
This allows a custom span buffer size to be set. Following the convention already set with the custom sampler logic; all that was added was
SetSpansBufferSizemethod which creates a new buffer of sizemaxSize intand replaces the old buffer in the current tracer with the new one. This adds the new functionality of being able to create custom buffers sizes while not modifying any of the existing API's making it a safe update for anyone using this library.Let me know if you have any suggestions/comments/concerns.