contrib/gocql/gocql: report readable consistency instead of int #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
changed the title
|
Thanks Christian. Makes complete sense. I'll approve once I fix this CI annoyance. |
gbbr
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a suggestion, the current integration works fine, but I tend to prefer reading
QUORUMrather then4, it seems more straightforward when reading spans meta in the UI.As a side node, this
String()method seems to have been there for quite some time (eg in this 4 year old commit: apache/cassandra-gocql-driver@c78c7ab#diff-f2fccfb96064097b73fbe8eeae3703eeR477)Again, it's just a nitpick, and there might be reasons for keeping the number.