contrib/gocql/gocql: report readable consistency instead of int #348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a suggestion, the current integration works fine, but I tend to prefer reading
QUORUM
rather then4
, it seems more straightforward when reading spans meta in the UI.As a side node, this
String()
method seems to have been there for quite some time (eg in this 4 year old commit: apache/cassandra-gocql-driver@c78c7ab#diff-f2fccfb96064097b73fbe8eeae3703eeR477)Again, it's just a nitpick, and there might be reasons for keeping the number.