Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/gocql/gocql: report readable consistency instead of int #348

Merged
merged 2 commits into from
Oct 24, 2018

Conversation

ufoot
Copy link
Member

@ufoot ufoot commented Oct 24, 2018

Just a suggestion, the current integration works fine, but I tend to prefer reading QUORUM rather then 4, it seems more straightforward when reading spans meta in the UI.

As a side node, this String() method seems to have been there for quite some time (eg in this 4 year old commit: apache/cassandra-gocql-driver@c78c7ab#diff-f2fccfb96064097b73fbe8eeae3703eeR477)

Again, it's just a nitpick, and there might be reasons for keeping the number.

@ufoot ufoot requested a review from gbbr October 24, 2018 10:40
@gbbr gbbr changed the title [contrib:gocql] report readable consistency instead of int contrib/gocql/gocql: report readable consistency instead of int Oct 24, 2018
@gbbr
Copy link
Contributor

gbbr commented Oct 24, 2018

Thanks Christian. Makes complete sense. I'll approve once I fix this CI annoyance.

@gbbr gbbr added this to the next milestone Oct 24, 2018
@gbbr gbbr merged commit 93a02b5 into v1 Oct 24, 2018
@gbbr gbbr deleted the christian/gocqlconsistency branch October 24, 2018 11:22
mingrammer pushed a commit to mingrammer/dd-trace-go that referenced this pull request Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants